Add support for controlling PVC retention policy in 2 charts#159
Merged
jacekn merged 2 commits intostellar:mainfrom Apr 10, 2026
Merged
Add support for controlling PVC retention policy in 2 charts#159jacekn merged 2 commits intostellar:mainfrom
jacekn merged 2 commits intostellar:mainfrom
Conversation
This PR adds support for controlling PVC retention policy using persistentVolumeClaimRetentionPolicy. Default behaviour doesn't change so this PR is backwards compabitle.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an opt-in Helm values surface to control StatefulSet PVC retention behavior for the core and soroban-rpc charts via spec.persistentVolumeClaimRetentionPolicy, while keeping the default behavior unchanged.
Changes:
- Document
persistentVolumeClaimRetentionPolicyunder each chart’spersistencevalues. - Conditionally render
spec.persistentVolumeClaimRetentionPolicyin both StatefulSet templates. - Bump chart versions for
coreandsoroban-rpc.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/soroban-rpc/values.yaml | Documents new optional persistence retention policy values. |
| charts/soroban-rpc/templates/soroban-rpc-sts.yaml | Conditionally renders StatefulSet persistentVolumeClaimRetentionPolicy. |
| charts/soroban-rpc/Chart.yaml | Version bump to reflect added configuration surface. |
| charts/core/values.yaml | Documents new optional persistence retention policy values. |
| charts/core/templates/core-sts.yaml | Conditionally renders StatefulSet persistentVolumeClaimRetentionPolicy. |
| charts/core/Chart.yaml | Version bump to reflect added configuration surface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
satyamz
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for controlling PVC retention policy using persistentVolumeClaimRetentionPolicy.
Default behaviour doesn't change so this PR is backwards compabitle.